Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Change collection child type to kind name #149

Merged
merged 1 commit into from
Mar 3, 2023
Merged

[python] Change collection child type to kind name #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python-spec/src/somacore/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def create(
def add_new_collection(
self,
key: str,
cls: None = None,
kind: None = None,
*,
uri: Optional[str] = ...,
platform_config: Optional[options.PlatformConfig] = ...,
Expand All @@ -66,7 +66,7 @@ def add_new_collection(
def add_new_collection(
self,
key: str,
cls: Type[_CT],
kind: Type[_CT],
*,
uri: Optional[str] = ...,
platform_config: Optional[options.PlatformConfig] = ...,
Expand All @@ -77,7 +77,7 @@ def add_new_collection(
def add_new_collection(
self,
key: str,
cls: Optional[Type["BaseCollection"]] = None,
kind: Optional[Type["BaseCollection"]] = None,
*,
uri: Optional[str] = None,
platform_config: Optional[options.PlatformConfig] = None,
Expand Down Expand Up @@ -115,7 +115,7 @@ def add_new_collection(

:param key: The key that this child should live at (i.e., it will be
accessed via ``the_collection[key]``).
:param cls: The type of child that should be added.
:param kind: The type of child that should be added.
:param uri: If provided, overrides the default URI that would be used
to create this object. This may be absolute or relative.
:param platform_config: Platform-specific configuration options used
Expand Down