Make options.responseType optional when using a template

Fixes #1178
sindresorhus · May 3, 2020 · 9ed0a39 · 9ed0a39
1 parent 50ef99a
commit 9ed0a39
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/source/types.ts b/source/types.ts
@@ -42,7 +42,7 @@ export interface ExtendOptions extends Options {
 }
 
 export type OptionsOfTextResponseBody = Merge<Options, {isStream?: false; resolveBodyOnly?: false; responseType?: 'text'}>;
-export type OptionsOfJSONResponseBody = Merge<Options, {isStream?: false; resolveBodyOnly?: false; responseType: 'json'}>;
+export type OptionsOfJSONResponseBody = Merge<Options, {isStream?: false; resolveBodyOnly?: false; responseType?: 'json'}>;
 export type OptionsOfBufferResponseBody = Merge<Options, {isStream?: false; resolveBodyOnly?: false; responseType: 'buffer'}>;
 export type StrictOptions = Except<Options, 'isStream' | 'responseType' | 'resolveBodyOnly'>;
 export type StreamOptions = Merge<Options, {isStream?: true}>;

diff --git a/test/response-parse.ts b/test/response-parse.ts
@@ -1,5 +1,6 @@
 import test from 'ava';
 import {Handler} from 'express';
+import getStream = require('get-stream');
 import {HTTPError, ParseError} from '../source';
 import withServer from './helpers/with-server';
 
@@ -222,3 +223,16 @@ test('shortcuts result properly when retrying in afterResponse', withServer, asy
 	t.is(text, proper);
 	t.is(buffer.compare(Buffer.from(proper)), 0);
 });
+
+test('responseType is optional when using template', withServer, async (t, server, got) => {
+	const data = {hello: 'world'};
+
+	server.post('/', async (request, response) => {
+		response.end(await getStream(request));
+	});
+
+	const jsonClient = got.extend({responseType: 'json'});
+	const {body} = await jsonClient.post<typeof data>('', {json: data});
+
+	t.deepEqual(body, data);
+});