Run CI on Node 22 #129
Merged
Run CI on Node 22 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
May 4, 2024
| t.is(new Uint8Array(bufferedData)[0], 0); | ||
| }); | ||
|
|
||
| const CHUNK_SIZE = 2 ** 16; |
There was a problem hiding this comment.
Node 22 increased the maximum size of Buffer and ArrayBuffer from 4GB to 75GB. This is too high to be able to run this test without either crashing the process or making the test run for too long.
Thankfully, we run a similar test but for the other methods getStream(), etc. so they should be covering that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the CI on Node 22.