Add TypeScript definition #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide? Some examples: |
sindresorhus
requested changes
Apr 12, 2020
|
Please look at the styleguide a little bit more thoroughly. |
|
@connor4312 Friendly bump :) |
|
Been a busy month in VS Code land. The first week of every month-long iteration is debt week; I will take care of this in the upcoming debt week in August 🙂 |
|
I've updated the PR. However I'm having a difficult time trying to find the exact set of ava/xo versions needed to make the build work while keeping the Node 4 target. Since #6 updates to Node 8, I left things as they were. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.