Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write empty "standerr:" lines to verbose progress output #348

Open
rmunn opened this issue Aug 14, 2024 · 0 comments · May be fixed by #349
Open

Don't write empty "standerr:" lines to verbose progress output #348

rmunn opened this issue Aug 14, 2024 · 0 comments · May be fixed by #349
Assignees

Comments

@rmunn
Copy link
Contributor

rmunn commented Aug 14, 2024

Many times the verbose progress log will contain things like the following:

   Using cached result: log -r0 --template "{node}" 
   standerr: 
   
   standout: 4173623d30060fb329fffb3d90fb36027aeb6a83
   
   Using cached result: log -r0 --template "{node}" 
   standerr: 
   
   standout: 4173623d30060fb329fffb3d90fb36027aeb6a83

There's no need to write the standerr section if it's blank, and there's also no need to double up on the final newline from standard output. IProgress.WriteVerbose already writes a newline, so we should trim the extra newline before writing it, and skip writing something entirely if there's no meaningful output (it's just a newline, for example).

@rmunn rmunn self-assigned this Aug 14, 2024
@rmunn rmunn linked a pull request Aug 14, 2024 that will close this issue
@rmunn rmunn linked a pull request Aug 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant