You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current development process of the go-ora project, we have identified several errors. These bugs can be detected through basic code inspection and unit testing.
As highlighted in #580, if we executing the TestBinaryFloat test reveals that the function fails. However, due to issues with code organization and compilation configurations in the current go-ora project, these automated checks are not functioning.
Therefore, if we fix the compilation issues and enable the automated code inspection and testing system, it will facilitate identifying, resolving, and preventing such problems.
To implement these changes, we might need to follow these steps:
Fix the issues in go.mod. Currently, the v1 and v2 go.mod files cannot compile directly.
Rewrite the GitHub Action to ensure the code compiles automatically.
Enable automated code testing and fix the test and lint issues on a case-by-case basis to enhance our code robustness. Perhaps, we can initially comment out some tests that cannot pass and address them one by one?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
In the current development process of the go-ora project, we have identified several errors. These bugs can be detected through basic code inspection and unit testing.
For instance, some errors are not caught, such as those in the following lines:
https://github.com/sijms/go-ora/blob/master/network/session.go#L610-L611
https://github.com/sijms/go-ora/blob/master/network/session.go#L734
As highlighted in #580, if we executing the
TestBinaryFloat
test reveals that the function fails. However, due to issues with code organization and compilation configurations in the current go-ora project, these automated checks are not functioning.Therefore, if we fix the compilation issues and enable the automated code inspection and testing system, it will facilitate identifying, resolving, and preventing such problems.
To implement these changes, we might need to follow these steps:
@sijms what do you think about this?
Beta Was this translation helpful? Give feedback.
All reactions