Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated connection limits checks #6156

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Remove duplicated connection limits checks #6156

merged 6 commits into from
Oct 11, 2024

Commits on Jul 23, 2024

  1. move main Behaviour to mod.rs for better readibility 

    and remove connection limits checks after connection has been established,

as those checks have already been done by connection limits Behaviour.
    @jxs
    jxs committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    44b2792 View commit details
    Browse the repository at this point in the history

  2. improve logging wording wrt dial logic 

    when we call dial_peer we are not yet dialing but just adding the peer to the dial queue
    @jxs
    jxs committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6d7bea4 View commit details
    Browse the repository at this point in the history

  3. do not use a constant for MAX_CONNECTIONS_PER_PEER 

    we only use it at one place, and the function call is explicit.
    @jxs
    jxs committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1df81da View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. address review and re-instate connection limits checks, 

    but do it before the connection has been established.
    @jxs
    jxs committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    bda9447 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'unstable' of github.com:sigp/lighthouse into remove-dia… 

    …l-error-denied
    @jxs
    jxs committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    196f1e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'unstable' of github.com:sigp/lighthouse into remove-dia… 

    …l-error-denied
    @jxs
    jxs committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    80a2444 View commit details
    Browse the repository at this point in the history