Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase penalty for old block gossip spam #6050

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Simplified and streamlined version of:

Proposed Changes

We're still seeing a lot of stale pre-finalization blocks being gossiped by Erigon/Caplin. To encourage users to update to a non-buggy version, this PR increases the peer penalty which will result in more frequent bans.

As far as I can tell there are no cases where honest peers should be gossiping blocks prior to finalization. If a peer is syncing, they should not be broadcasting the blocks they're syncing on gossip. In case of a consensus fault and chain split, it's somewhat irrelevant whether the two sides of the split remain connected to each other, as the damage has already been done by finalizing and nodes will need to be manually resynced to the correct chain. E.g. if Lighthouse-Geth finalizes an invalid checkpoint, then it will view the (valid) minority chain as conflicting with its view of finalization. There is no way it will continue importing blocks from the valid chain until its DB is blown away to revert the faulty finalization. Most attached validators (ones that attested to the invalid finalization) will also be lost at this point (leaked out to 0).

Additional Info

Related to:

@michaelsproul michaelsproul added ready-for-review The code is ready for review Networking v5.3.0 Q3 2024 release with database changes! labels Jul 5, 2024
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All for banning bad behaviour

@michaelsproul
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Jul 5, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 94d55be

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 5, 2024
mergify bot added a commit that referenced this pull request Jul 5, 2024
@mergify mergify bot merged commit 94d55be into sigp:unstable Jul 5, 2024
28 checks passed
@michaelsproul michaelsproul deleted the stale-gossip-blocks branch July 5, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants