Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade duplication log of attestation to Debug #6007

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Jun 27, 2024

Issue Addressed

Proposed Changes

Only display the first log of Attestation included in aggregate and Attestation included in block as INFO and downgrade subsequent logs to DEBG. This will reduce verbosity of the logs when validator-monitor-auto is turned on.

Additional Info

For Attestation included in aggregate:

Before:

Jun 23 13:04:44.195 INFO Attestation included in aggregate, validator: x, src: gossip, slot: 1937123, epoch: 60535, delay_ms: 187, index: 25, head: 0x423bdb9a0376d74a5315454610527f30c1d943098df501d69ff38b1512e81c19, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1385
Jun 23 13:04:44.317 INFO Attestation included in aggregate, validator: x, src: gossip, slot: 1937123, epoch: 60535, delay_ms: 272, index: 25, head: 0x423bdb9a0376d74a5315454610527f30c1d943098df501d69ff38b1512e81c19, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1385
Jun 23 13:04:44.380 INFO Attestation included in aggregate, validator: x, src: gossip, slot: 1937123, epoch: 60535, delay_ms: 310, index: 25, head: 0x423bdb9a0376d74a5315454610527f30c1d943098df501d69ff38b1512e81c19, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1385

After:

Jun 27 01:34:32.246 INFO Attestation included in aggregate, validator: x, src: gossip, slot: 1962472, epoch: 61327, delay_ms: 208, index: 17, head: 0xeb08a01a9ee36448c9b7313a5df4834bdcf3d5b576851c87e46ed91aa499b625, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1397
Jun 27 01:34:32.306 DEBG Attestation included in aggregate, validator: x, src: gossip, slot: 1962472, epoch: 61327, delay_ms: 301, index: 17, head: 0xeb08a01a9ee36448c9b7313a5df4834bdcf3d5b576851c87e46ed91aa499b625, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1410
Jun 27 01:34:32.386 DEBG Attestation included in aggregate, validator: x, src: gossip, slot: 1962472, epoch: 61327, delay_ms: 373, index: 17, head: 0xeb08a01a9ee36448c9b7313a5df4834bdcf3d5b576851c87e46ed91aa499b625, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1410

For Attestation included in block:

Before:

Jun 26 12:16:50.029 INFO Attestation included in block, validator: x, slot: 1958483, epoch: 61202, inclusion_lag: 0 slot(s), index: 35, head: 0xe4e89134dc9aa0c1ca7c75c16c3d4f94ce3ec5054d33a800ab3e735b858ee301, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1470
Jun 26 12:16:50.041 INFO Attestation included in block, validator: x, slot: 1958483, epoch: 61202, inclusion_lag: 0 slot(s), index: 35, head: 0xe4e89134dc9aa0c1ca7c75c16c3d4f94ce3ec5054d33a800ab3e735b858ee301, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1470

After:

Jun 27 01:34:37.504 INFO Attestation included in block, validator: x, slot: 1962472, epoch: 61327, inclusion_lag: 0 slot(s), index: 17, head: 0xeb08a01a9ee36448c9b7313a5df4834bdcf3d5b576851c87e46ed91aa499b625, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1482
Jun 27 01:34:50.587 DEBG Attestation included in block, validator: x, slot: 1962472, epoch: 61327, inclusion_lag: 1 slot(s), index: 17, head: 0xeb08a01a9ee36448c9b7313a5df4834bdcf3d5b576851c87e46ed91aa499b625, service: val_mon, service: beacon, module: beacon_chain::validator_monitor:1493

@chong-he chong-he added work-in-progress PR is a work-in-progress UX-and-logs labels Jun 27, 2024
@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jul 1, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks CK!

@michaelsproul
Copy link
Member

@mergify queue

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes! and removed ready-for-review The code is ready for review labels Jul 4, 2024
Copy link

mergify bot commented Jul 4, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d9ad1f5

mergify bot added a commit that referenced this pull request Jul 4, 2024
@mergify mergify bot merged commit d9ad1f5 into sigp:unstable Jul 4, 2024
28 checks passed
@chong-he chong-he deleted the attestation branch July 16, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. UX-and-logs v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants