Add PeerDAS DataColumn type #5913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
force-pushed
the
das-columns-type
branch
from
89bcc3e
to
50dab54
Compare
dapplion
added
ready-for-review
|
There has been very little interest in progressively merging PeerDAS in atomic PRs so I wave a white flag and join the group of yoloing |
|
I thought I already waved mine a while ago 😅 |
pawanjay176
reviewed
Jun 28, 2024
|
What a comeback! 🔥 We should include Kev's lib in this PR to have mock crypto |
Co-authored-by: Jacob Kaufmann <jacobkaufmann18@gmail.com> Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
dapplion
force-pushed
the
das-columns-type
branch
from
50dab54
to
8ddc6c4
Compare
pawanjay176
approved these changes
Jul 5, 2024
| type KzgCommitmentInclusionProofDepth = U17; | ||
| type KzgCommitmentsInclusionProofDepth = U4; // inclusion of the whole list of commitments |
There was a problem hiding this comment.
Just noting that the naming here is really confusing (w.r.t KzgCommitmentInclusionProofDepth) and has a potential for logic errors. Maybe we can address the naming in the spec
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 15985b8 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
First step to progressively merge
dasintounstable. Almost all changes use theDataColumnSidecartype so its a pre-requisite for anything else.DataColumnSidecarincludes some methods that require a newer version ofckzg-4844. Currently, these changes live in the das branch https://github.com/ethereum/c-kzg-4844/tree/das. I propose to merge theDataColumnSidecarwith no-op crypto untilc-kzg-4844changes land on main, which should happen in < 2 months.Since this PR does not introduce any actual functionality of PeerDAS it does not make a big difference to have the actual crypto backend. Once we merge enough pieces of the
dasbranch to be able to run a PeerDAS node we can switch toc-kzg-4844/das.Proposed Changes
Introduce the
DataColumnSidecartype fromUpstream PRs
c-kzg. #5701recover_cells_and_compute_proofsmethod #5938