Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electra engine api #5743

Merged
merged 190 commits into from
Jul 1, 2024
Merged

Electra engine api #5743

merged 190 commits into from
Jul 1, 2024

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Implements electra engine api.

Additional Info

The spec does not handle the engine_getPayloadBodies for the new electra fields. We need to add it to the spec and implement it.
This PR currently implements it in the manner that I think it will be implemented (i.e. by extending ExecutionPayloadBodyV1 to include deposit_receipts and withdrawal_requests.
Working on getting a spec out for this.

eserilev and others added 30 commits April 30, 2024 11:49
@eserilev
Attestation superstruct changes for EIP 7549 (#5644)
3b7132b 
* update

* experiment

* superstruct changes

* revert

* superstruct changes

* fix tests

* indexed attestation

* indexed attestation superstruct

* updated TODOs
@ethDreamer @michaelsproul
superstruct the AttesterSlashing (#5636)
e6c7f14 
* `superstruct` Attester Fork Variants

* Push a little further

* Deal with Encode / Decode of AttesterSlashing

* not so sure about this..

* Stop Encode/Decode Bounds from Propagating Out

* Tons of Changes..

* More Conversions to AttestationRef

* Add AsReference trait (#15)

* Add AsReference trait

* Fix some snafus

* Got it Compiling! :D

* Got Tests Building

* Get beacon chain tests compiling

---------

Co-authored-by: Michael Sproul <micsproul@gmail.com>
@ethDreamer
Merge remote-tracking branch 'upstream/unstable' into electra_attesta…
3a41e13 
…tion_changes
@ethDreamer
Make EF Tests Fork-Agnostic (#5713)
9b98f4e
@ethDreamer
Finish EF Test Fork Agnostic (#5714)
7c6526d
@ethDreamer
Superstruct AggregateAndProof (#5715)
19a9479 
* Upgrade `superstruct` to `0.8.0`

* superstruct `AggregateAndProof`
@realbigsean
Merge remote-tracking branch 'sigp/unstable' into electra_attestation…
9f6de8e 
…_changes
@realbigsean
cargo fmt
38382a3
@realbigsean
Merge pull request #5726 from realbigsean/electra_attestation_changes
2c2e44c 
Merge unstable into Electra attestation changes
@realbigsean
process withdrawals updates
e2e82ff
@realbigsean
cleanup withdrawals processing
e0abede
@realbigsean
update process_operations deposit length check
f1f9f92
@realbigsean
add apply_deposit changes
3c68841
@realbigsean
add execution layer withdrawal request processing
1d5f755
@realbigsean
process deposit receipts
32357d8
@realbigsean
add consolidation processing
c40bec9
@realbigsean
update process operations function
31955c2
@realbigsean
exit updates
75ab913
@realbigsean
clean up
5728f78
@realbigsean
update slash_validator
8517236
@eserilev
EIP7549 get_attestation_indices (#5657)
90179d4 
* get attesting indices electra impl

* fmt

* get tests to pass

* fmt

* fix some beacon chain tests

* fmt

* fix slasher test

* fmt got me again

* fix more tests

* fix tests
@ethDreamer
Some small changes (#5739)
f30246b
@realbigsean
Merge branch 'electra_attestation_changes' of https://github.com/sigp…
7c0a8f8 
…/lighthouse into block-processing-electra
@ethDreamer
cargo fmt (#5740)
43c3f63
@realbigsean
Merge branch 'electra_attestation_changes' of https://github.com/sigp…
721e73f 
…/lighthouse into block-processing-electra
@realbigsean
fix attestation verification
7abb762
@pawanjay176
Add new engine api methods
42a4993
@pawanjay176
Fix the versioning of v4 requests
ca2a946
@pawanjay176
Handle new engine api methods in mock EL
1ddd078
@pawanjay176
Note todo
3ef7c90
realbigsean and others added 10 commits June 21, 2024 10:48
@realbigsean
Update slasher/src/database.rs
09141ec
@realbigsean
fix imports
8fc5333
@realbigsean
Merge pull request #5980 from dapplion/electra-lightclient
5517c78 
Add electra lightclient types
@realbigsean
Merge pull request #5975 from michaelsproul/electra-slasher-no-migration
cf030d0 
Avoid changing slasher schema for Electra
@realbigsean
Update beacon_node/beacon_chain/src/attestation_verification.rs
68fd7a7
@realbigsean
Update beacon_node/beacon_chain/src/attestation_verification.rs
d137881
@realbigsean
Merge branch 'unstable' of https://github.com/sigp/lighthouse into el…
87fde51 
…ectra_attestation_changes
@realbigsean
Merge branch 'electra_attestation_changes' of https://github.com/real…
a8d84d6 
…bigsean/lighthouse into block-processing-electra
@realbigsean
Merge branch 'block-processing-electra' of https://github.com/sigp/li…
51a8c80 
…ghthouse into electra-epoch-proc
@realbigsean
Merge branch 'electra-epoch-proc' of https://github.com/sigp/lighthouse…
4a858b3 
… into electra-engine-api
Base automatically changed from block-processing-electra to unstable June 26, 2024 13:29
@realbigsean realbigsean removed the skip-ci Don't run the `test-suite` label Jun 26, 2024
@realbigsean realbigsean changed the base branch from unstable to electra-epoch-proc June 26, 2024 15:12
@realbigsean
Copy link
Member

Is it intentional to merge epoch processing changes into this branch?

Yes since we were planning to merge it into unstable after epoch processing, re-targeted the branch to fix the diff

@realbigsean
Copy link
Member

Something that's missing is the payload bodies by range changes: ethereum/execution-apis#545

This PR implements an extension of the existing V1 endpoint, what's currently spec'd is to actually add a V2 endpoint: ethereum/execution-apis#545 (comment)

There may be further discussion about whether to just extend v1 but for now we won't be able to serve blocks whose payloads we've pruned until we implement this as a v2

We could use the same ExecutionPayloadBody type for both v1 and v2 because v2 is fully backwards compatible but there will be annoying fork-switching logic we we want to query the v2 endpoint after the electra fork so we're sure the EL supports it

@pawanjay176
Copy link
Member Author

Strong agree on extending V1. We can implement the V2 method but its unnecessarily complex and gains us nothing imo.

Base automatically changed from electra-epoch-proc to unstable June 28, 2024 23:43
realbigsean
realbigsean approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop!

beacon_node/beacon_chain/src/electra_readiness.rs Outdated Show resolved Hide resolved
consensus/types/src/chain_spec.rs Outdated Show resolved Hide resolved
@realbigsean
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jul 1, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 2a13b4f

@mergify mergify bot mentioned this pull request Jul 1, 2024
Closed
5 tasks
mergify bot added a commit that referenced this pull request Jul 1, 2024
@mergify
Merge of #5743
3a08e68
@mergify mergify bot merged commit 2a13b4f into unstable Jul 1, 2024
28 checks passed
@mergify mergify bot deleted the electra-engine-api branch July 1, 2024 16:33
@realbigsean realbigsean restored the electra-engine-api branch July 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

@ethDreamer ethDreamer ethDreamer left review comments

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
electra Required for the Electra/Prague fork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pawanjay176 @realbigsean @dapplion @ethDreamer @eserilev @michaelsproul @mattsse