-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deneb builder test & update mock builder #4607
Add Deneb builder test & update mock builder #4607
Conversation
…n/lighthouse into add-mock-builder-deneb-support
66be8c2
to
6752198
Compare
It looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! I reviewed Mark's blob clone PR so maybe we add that one in first
@@ -9,9 +9,22 @@ use superstruct::superstruct; | |||
use test_random_derive::TestRandom; | |||
use tree_hash_derive::TreeHash; | |||
|
|||
pub type KzgCommitments<T> = | |||
pub type KzgCommitments<T> = VariableList<KzgCommitment, <T as EthSpec>::MaxBlobsPerBlock>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this gets merged ethereum/builder-specs#87
It'd be nice not to have to introduce this type. It makes things quite confusing IMO
Changes
KzgCommitments
in BlobsBundle, as theKzgCommitments
inBlockBody
has a different max size:lighthouse/consensus/types/src/beacon_block_body.rs
Lines 12 to 14 in 66be8c2
mock-builder
to support Deneb types from updatedmev-rs
andethereum-consensus
libsshardingForkTime
tocancunTime
in local testnet scriptsAdditional Info
RUST_MIN_STACK=8388608
: 4mb thread stack limit wasnt enough, looks like we really need to get @ethDreamer's eliminate blob clone PR in.get_header
timeout: 1 second timeout wasn't enough when running in debug - I think we might even want to override this in tests via env vars, as it's likely that mock builder requires more time to return a response.mock-relay
that contains expected withdrawals changes cherry-picked from [Merged by Bors] - Implement expected withdrawals endpoint #4390. I've excluded it from this PR as expected withdrawals endpoint change is still under review.