Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): HTTP error handling in VC API #4598

Closed
wants to merge 2 commits into from
Closed

(fix): HTTP error handling in VC API #4598

wants to merge 2 commits into from

Conversation

protocolwhisper
Copy link

Issue Addressed

Closes #4597

Proposed Changes

Eliminate all instances of Warp's "and_then" (which backtracks) and replace them with "then" (which doesn't perform backtracking).

Additional Info

No

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to change the handlers themselves to return Response rather than Result<Response, warp::Rejection>.

Changing the definition of blocking_signed_json_task so that it uses something similar to convert_rejection (see my PR) would be one way to do it.

Try running make lint locally and getting it to suceed. You'll also want to rebase on unstable (your PR currently has conflicts because you started from stable).

@protocolwhisper protocolwhisper closed this by deleting the head repository Aug 10, 2023
@protocolwhisper
Copy link
Author

protocolwhisper commented Aug 10, 2023

@michaelsproul. I have just created a new PR #4606 following your guidance. I believe I have covered the necessary changes, but the make lint command is failing. Interestingly, the failures originate from other modules, specifically within consensus/types/src/, rather than the changes made in this PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants