Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single blob lookups #4152

Merged
merged 117 commits into from
Jun 15, 2023
Merged

Single blob lookups #4152

merged 117 commits into from
Jun 15, 2023

Conversation

realbigsean
Copy link
Member

Issue Addressed

Which issue # does this PR address?

Proposed Changes

Please list or describe the changes introduced by this PR.

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

@realbigsean realbigsean added work-in-progress PR is a work-in-progress deneb labels Mar 31, 2023
@realbigsean realbigsean changed the title Some blob reprocessing work Single blob lookups Mar 31, 2023
realbigsean and others added 23 commits March 31, 2023 10:45
@realbigsean
impl logic for triggerng blob lookups along with block lookups
a17405a
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
22694d1 
…into some-blob-reprocessing-work
@realbigsean
deal with rpc blobs in groups per block in the da checker. don't cach…
6f12df3 
…e missing blob ids in the da checker.
@realbigsean
make single block lookup generic
38e0994
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
66e09f4 
…into some-blob-reprocessing-work
@realbigsean
more work
25ff6e8
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
2f8c885 
…into some-blob-reprocessing-work
@realbigsean
add delayed processing logic and combine some requests
8618c30
@realbigsean
start fixing some compile errors
195d802
@realbigsean
fix compilation in main block lookup mod
0ad9fdf
@realbigsean
much work
374ec48
@realbigsean
get things compiling
c714249
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
0cc1704 
…into some-blob-reprocessing-work
@realbigsean
parent blob lookups
bacec52
@realbigsean
fix compile
3e854ae
@pawanjay176
revert red/stevie changes
d8ed811
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
b2a4c4e 
…into some-blob-reprocessing-work
@realbigsean
Merge branch 'some-blob-reprocessing-work' of https://github.com/real…
269122f 
…bigsean/lighthouse into some-blob-reprocessing-work
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
03de817 
…into some-blob-reprocessing-work
@realbigsean
fix up sync manager delay message logic
93df0f5
@realbigsean
add peer usefulness enum
381044a
@realbigsean
should remove lookup refactor
b6531aa
@realbigsean
consolidate retry error handling
274aba9
@realbigsean
use interval instead of sleep
61b1a11
@realbigsean
drop request if blocks and blobs requests both return None for Id
a69b4af
@realbigsean
clean up find_single_lookup logic
ef8630c
@realbigsean
add lookup source enum
2a1ea23
@realbigsean
clean up find_single_lookup logic
2d5a256
@realbigsean
add docs to find_single_lookup_request
59df842
@realbigsean
move LookupSource our of param where unnecessary
3b84894
@realbigsean
remove unnecessary todo
db20e2e
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
52ed9ab 
…into some-blob-reprocessing-work
@realbigsean
query for block by state.latest_block_header.slot
36309d3
@realbigsean
Merge branch 'deneb-free-blobs' of https://github.com/sigp/lighthouse …
b61772e 
…into some-blob-reprocessing-work
@realbigsean
fix lint
1c240fc
@realbigsean
fix test
4dd2130
@realbigsean
fix test
5a2026a
@realbigsean
Merge branch 'checkpoint-sync-without-alignment' of https://github.co…
7887d40 
…m/realbigsean/lighthouse into some-blob-reprocessing-work
@realbigsean
fix observed blob sidecars test
cf875ba
pawanjay176
pawanjay176 reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments, almost done now

beacon_node/network/src/sync/manager.rs Outdated Show resolved Hide resolved
beacon_node/network/src/sync/block_lookups/mod.rs Outdated Show resolved Hide resolved
pawanjay176
pawanjay176 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this looks good to me now
Herculean effort getting this through 🙌 merge at will

@realbigsean
Copy link
Member Author

Thank you very much for the very thorough review 🙏

@realbigsean realbigsean merged commit a62e52f into sigp:deneb-free-blobs Jun 15, 2023
@realbigsean realbigsean mentioned this pull request Jun 29, 2023
Closed
@realbigsean realbigsean deleted the some-blob-reprocessing-work branch November 21, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian left review comments

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
deneb ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@realbigsean @pawanjay176 @divagant-martian @ethDreamer