-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - v2.2.1 #3149
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving this here pending testing over the weekend on SigP nodes. |
commit aa5d93d Author: Paul Hauner <paul@paulhauner.com> Date: Fri Apr 8 14:16:44 2022 +1000 Use existing `execution_engine`
Blocked on #3150 |
michaelsproul
added
ready-for-review
The code is ready for review
and removed
blocked
do-not-merge
labels
Apr 12, 2022
paulhauner
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG!
bors r+
bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
## Issue Addressed Addresses sync stalls on v2.2.0 (i.e. #3147). ## Additional Info I've avoided doing a full `cargo update` because I noticed there's a new patch version of libp2p and thought it could do with some more testing. Co-authored-by: Paul Hauner <paul@paulhauner.com>
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Apr 12, 2022
Build failed: |
The ole zero port race condition bors retry |
bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
## Issue Addressed Addresses sync stalls on v2.2.0 (i.e. #3147). ## Additional Info I've avoided doing a full `cargo update` because I noticed there's a new patch version of libp2p and thought it could do with some more testing. Co-authored-by: Paul Hauner <paul@paulhauner.com>
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Issue Addressed Addresses sync stalls on v2.2.0 (i.e. sigp#3147). ## Additional Info I've avoided doing a full `cargo update` because I noticed there's a new patch version of libp2p and thought it could do with some more testing. Co-authored-by: Paul Hauner <paul@paulhauner.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses sync stalls on v2.2.0 (i.e. #3147).
Additional Info
I've avoided doing a full
cargo update
because I noticed there's a new patch version of libp2p and thought it could do with some more testing.