[Merged by Bors] - Add API version headers and map_fork_name!
#2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
force-pushed
the
api-fork-header
branch
from
6106600
to
ca39a7a
Compare
realbigsean
approved these changes
Oct 27, 2021
paulhauner
added
ready-for-merge
|
Thank you both! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
## Proposed Changes * Add the `Eth-Consensus-Version` header to the HTTP API for the block and state endpoints. This is part of the v2.1.0 API that was recently released: ethereum/beacon-APIs#170 * Add tests for the above. I refactored the `eth2` crate's helper functions to make this more straight-forward, and introduced some new mixin traits that I think greatly improve readability and flexibility. * Add a new `map_with_fork!` macro which is useful for decoding a superstruct type without naming all its variants. It is now used for SSZ-decoding `BeaconBlock` and `BeaconState`, and for JSON-decoding `SignedBeaconBlock` in the API. ## Additional Info The `map_with_fork!` changes will conflict with the Merge changes, but when resolving the conflict the changes from this branch should be preferred (it is no longer necessary to enumerate every fork). The merge fork _will_ need to be added to `map_fork_name_with`.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
map_fork_name!map_fork_name!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Eth-Consensus-Versionheader to the HTTP API for the block and state endpoints. This is part of the v2.1.0 API that was recently released: Add version header for ssz responses ethereum/beacon-APIs#170eth2crate's helper functions to make this more straight-forward, and introduced some new mixin traits that I think greatly improve readability and flexibility.map_with_fork!macro which is useful for decoding a superstruct type without naming all its variants. It is now used for SSZ-decodingBeaconBlockandBeaconState, and for JSON-decodingSignedBeaconBlockin the API.Additional Info
The
map_with_fork!changes will conflict with the Merge changes, but when resolving the conflict the changes from this branch should be preferred (it is no longer necessary to enumerate every fork). The merge fork will need to be added tomap_fork_name_with.