Skip to content

Commit

Permalink
fixup! fixup! Add todo for blobs by range
Browse files Browse the repository at this point in the history
  • Loading branch information
emhane committed Jan 19, 2023
1 parent b3ce10a commit 862deff
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions beacon_node/network/src/beacon_processor/worker/rpc_methods.rs
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,13 @@ impl<T: BeaconChainTypes> Worker<T> {
req.count = MAX_REQUEST_BLOCKS;
}

// todo(emhane): In the future, if the data availability boundary comes closer to the
// current_epoch - (2 epochs + "marginal for unhealthy network epochs") epoch, this code
// needs to be changed to account for head candidates. As it is not spec'd
// out how we should handle ByRoot request for blobs close to finalization which we might
// find a blobs sidecar for or just the block root in the DBColumn::BeaconBlobOrphan vector
// (vector introduced in Prune blobs PR
// https://github.com/sigp/lighthouse/pull/3852#pullrequestreview-1244785136 ).
let forwards_block_root_iter = match self
.chain
.forwards_iter_block_roots(Slot::from(req.start_slot))
Expand Down Expand Up @@ -660,13 +667,7 @@ impl<T: BeaconChainTypes> Worker<T> {
req.count = MAX_REQUEST_BLOBS_SIDECARS;
}

// todo(emhane): In the future, if the data availability boundary comes closer to the
// current_epoch - (2 epochs + "marginal for unhealthy network epochs") epoch, this code
// needs to be changed to account for head candidates. Unlike ByRoot, as it is not spec'd
// out how we should handle request for blobs close to finalization which we might find a
// blobs sidecar for or just the block root in the DBColumn::BeaconBlobOrphan vector
// (vector introduced in Prune blobs PR
// https://github.com/sigp/lighthouse/pull/3852#pullrequestreview-1244785136 ).
// todo(emhane): Account for head candidates.
let forwards_block_root_iter =
match self.chain.forwards_iter_block_roots(serve_blobs_from_slot) {
Ok(iter) => iter,
Expand Down

0 comments on commit 862deff

Please sign in to comment.