Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIC, packet size and Time-On-Air #123

Open
brunocitoni opened this issue May 29, 2022 · 0 comments
Open

MIC, packet size and Time-On-Air #123

brunocitoni opened this issue May 29, 2022 · 0 comments

Comments

@brunocitoni
Copy link

Expected Behavior

According to the specifications (either 1.04 or 1.1), each LoRa message should finish with a 4-octet message integrity code (MIC). I could not see this anywhere, and since I noticed the Time-on_air is slightly lower than it should be I assume that's the reason.
MACFrame

Actual Behavior

I could not see the MIC mentioned or implemented anywhere, and the Time-On-Air of the packets reflect this, with slightly lower time-on-air obtained via lora-phy.cc with respect to the calculators found online such as https://avbentem.github.io/airtime-calculator/ttn/eu868.

By adding 4 bytes to the LoRaFrameHeader (quick and dirty way) in lora-frame-header.cc (uint32_t size = 8 + m_fOptsLen + 4; in LoraFrameHeader::GetSerializedSize) the Time-on-Air is then correct.

Steps to Reproduce the Problem

  1. run a simulation by monitoring the return value for LoraPhy::GetOnAirTime
  2. compare to online time-on-air calculators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant