Import the non-FFI Rust sources of zkgroup #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of an effort to merge zkgroup into libsignal-client, including its Java, Swift, and TypeScript wrappers. For now we'll just concentrate on getting the Rust crate to build and pass its tests.
- Bump the version to 0.9.0, mainly so it doesn't get confused with the original repo. - Use the poksho in this repo and our custom 3.0.0-lizard2 branch of curve25519-dalek (instead of a 2.0.0-based one). - Bump the sha2 dependency to match curve25519-dalek 3.0. - Remove the reference to the crate's ffi module. With this, the tests pass and the benchmarks run.
jim-signal
reviewed
Oct 26, 2021
jim-signal
approved these changes
Oct 26, 2021
zkgroup uses capitalization to distinguish between scalar values and curve points, which is conventional in cryptography. However, *most* files aren't actually doing curve-level operations, and so they don't need to except themselves from having their names checked. Also, add deny(unsafe_code) to zkgroup. zkgroup shouldn't need any unsafe code; like the other crates, let's not bend that policy without a good reason.
jrose-signal
force-pushed
the
jrose/zkgroup
branch
from
7db6363
to
0f5f764
Compare
peter-signal
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of an effort to merge zkgroup into libsignal-client, including its Java, Swift, and TypeScript wrappers. For now we'll just concentrate on getting the Rust crate to build and pass its tests.
The first and second commits are mechanical changes that do not need review. Actually integrating zkgroup into the workspace was pretty straightforward as well: