Atomic processing of create/remove of keepalive thread #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpechane
force-pushed
the
keepalive-race
branch
from
05e781a
to
4680cb8
Compare
|
Thank you, Jiri! 🙇 |
|
Hey @shyiko, thanks for the quick merge! Do you have any ETA for a new release containing this fix? We've seen multiple reports related to this recently by Debezium users, so we'd love to have a new version we could pull in. |
|
0.19.0 uploaded to Maven Central. |
|
Excellent, thank you so much! Pulling that in right away.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connect() and disconnect() are called concurrently it is possible that keepalive thread is not stopped because it is created only after it was attempted to be destoryed. This leads to a leaking keepalive thread that also keeps to create and maintain an undesirable connection.
This PR thus creates and destroys keepalive thread in a single atomic block which gurantees proper ordering and removes the race condition.