Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

._getImgExAnn() function in sodad_split.py #36

Open
3 tasks done
mondayboy1 opened this issue Jul 30, 2024 · 1 comment
Open
3 tasks done

._getImgExAnn() function in sodad_split.py #36

mondayboy1 opened this issue Jul 30, 2024 · 1 comment

Comments

@mondayboy1
Copy link

Prerequisite

💬 Describe the reimplementation questions

Hi, I would like to ask if the "yMin = max(yMin, ymin)" in line 369 of sodad_spliy.py should be changed to "yMin = min(yMin, ymin)"? Otherwise, y_min will always be 10000
您好,请问sodad_spliy.py中第369行的_getImgExAnn()函数的"yMin = max(yMin, ymin)"是否应该改成yMin = min(yMin, ymin),否则输出的yMin 的值 永远都是10000

Environment

Same dependencies as in the repo.

Expected results

No response

Additional information

No response

@shaunyuan22
Copy link
Owner

right, thaks for pointing this error.
this won't affect the final results after splitting since imgExAnn is not used in func _divImg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants