Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.12 #1263

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Test on Python 3.12 #1263

merged 2 commits into from
Oct 11, 2024

Conversation

tomwhite
Copy link
Collaborator

No description provided.

@tomwhite
Copy link
Collaborator Author

The first cbgen version that supports Python 3.12 v10.0.5, but this requires NumPy 2, which is why this is failing.

See also #1218

@tomwhite tomwhite force-pushed the python-3.12 branch 2 times, most recently from 8f8b52e to ac2fe64 Compare September 30, 2024 12:29
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (51a8ffa) to head (094dc6c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines         4323      4323           
=========================================
  Hits          4323      4323           
Flag Coverage Δ
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Oct 10, 2024

This PR has conflicts, @tomwhite please rebase and push updated version 🙏

@mergify mergify bot added the conflict PR conflict label Oct 10, 2024
@mergify mergify bot removed the conflict PR conflict label Oct 11, 2024
@jeromekelleher
Copy link
Collaborator

Yeesh, this is looking hairy! Thanks for fighting the good fight here Tom!

…aints

Update flake8

Fix flake8 errors

Don't run pre-commit for NumPy 2 tests

Try installing latest bio2zarr at end

Replace pkg_resources with importlib.metadata
@tomwhite
Copy link
Collaborator Author

OK, I've got this passing now! There were a few things that needed fixing: the NumPy 2/cbgen/bio2zarr version constraints, and pkg_resources no longer being supported in Python 3.12.

@tomwhite tomwhite merged commit d1d5b77 into sgkit-dev:main Oct 11, 2024
10 checks passed
@tomwhite tomwhite deleted the python-3.12 branch October 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants