Change local alleles default to false #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-Tyler
force-pushed
the
local-alleles-default
branch
from
e7ad5c9
to
4e0efca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
vcf2zarr explodehas a CLI option to create local-allele fields during the explode process. Currently, the CLI option's default value is true. This pull request changes the default value to false.The default value should be false because the local alleles option is in an experimental stage of development. The current implementation does not save as much storage as hoped for and does not yet prevent the larger, global (non-local-allele) fields from being converted as well. See #277.
Testing
There are unit tests that test the default value of the local alleles option. I update those unit tests in this pull request.
References