Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup local alleles interface #272

Merged

Conversation

jeromekelleher
Copy link
Contributor

  • Add option to top-level convert function
  • Change so there is a single source of truth for the default

Note: the last point here is another reason I avoid hard-coding defaults in the signatures of functions.

- Add option to top-level convert function
- Change so there is a single source of truth for the default
@coveralls
Copy link
Collaborator

coveralls commented Jul 11, 2024

Coverage Status

coverage: 98.886% (+0.001%) from 98.885%
when pulling d407199 on jeromekelleher:local-alleles-interface
into d1e3e09 on sgkit-dev:main.

@jeromekelleher jeromekelleher merged commit 0768962 into sgkit-dev:main Jul 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants