Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM Package is not tested in CI #71

Open
sgb-io opened this issue Oct 24, 2023 · 0 comments
Open

WASM Package is not tested in CI #71

sgb-io opened this issue Oct 24, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sgb-io
Copy link
Owner

sgb-io commented Oct 24, 2023

An easy win would be to include the wasm-pack build --target web build to ensure it can compile.

This would avoid issues such as comfy-table being coupled between v0.1.11 and v1.0.0 which broke the wasm build
@sgb-io sgb-io added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgb-io