Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report]: Incorrect validation message for password change #7229

Closed
5 tasks done
edwardch opened this issue Aug 20, 2024 · 1 comment
Closed
5 tasks done

[Bug report]: Incorrect validation message for password change #7229

edwardch opened this issue Aug 20, 2024 · 1 comment
Assignees
Labels

Comments

@edwardch
Copy link
Contributor

Before submitting the bug report, please read and check the following items

What happened?

On the demo site, when changing a password, I enter SERENITY1 and the validation rule fails saying that a digit is required, even though there is a digit in the password.

It appears that the lower character error message is showing the digit message

https://github.com/serenity-is/common-features/blob/0354b790db9a45d80c2ad104a275458828ec7179/src/Serenity.Extensions/Modules/Membership/PasswordStrength/PasswordStrengthValidation.ts#L25

What did you expect to happen?

Show the lower character error if there is no lower character in the password and the password requires it.

How to reproduce?

  • via Forgot password email link
  • on the Account/ChangePassword page

What Serenity Nuget Versions are you seeing the problem on? (separated by comma)

8.6.x (Latest Demo)

Relevant log output

No response

Serene template version

8.6.2

Sergen version

No response

Code editor

Visual Studio 2022

Operating System

Windows 11

Node.js version

No response

TypeScript version

No response

Database type and version

No response

On which device do you see the problem?

Desktop

On which operating system do you see the problem?

Windows (11)

On which browsers do you see the problem?

Firefox, Microsoft Edge

On what version of the browsers do you see the problem?

Latest

Additional information

It would be useful to show the password requirements to the user based on what the configuration is.
e.g

Password requires:

  • at least one UPPERCASE character
  • at leat one lowercase character
  • at least one number from 0-9
  • at least one non alphanumeric character (e.g %$!/&)

what do you think?

@edwardch edwardch added the waiting-for-check Waiting Issue label Aug 20, 2024
@VictorTomaili VictorTomaili added bug and removed waiting-for-check Waiting Issue labels Aug 21, 2024
@volkanceylan
Copy link
Member

Should be fixed in 8.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants