Handle unconstrained priors in randomize_hyperparameters #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 24, 2023 09:07
…hyperparameters_prior_on
|
@uri-granta did you check @j-wilson PR where he also addressed the same issue: #794? |
AFAIU that's doing more than just fixing the bug in randomize_hyperparameters. Will look at that as soon as this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs: #793
Summary
Fix randomize_hyperparameters to handle unconstrained priors.
Also change the logic for handling Sigmoid constraints: we now prioritise sampling from the prior if there is one, and sample from the constrained domain only if there isn't.
Fully backwards compatible: no
New Sigmoid behaviour is more logical and flexible, and old behaviour can be easily obtained by removing any prior.
PR checklist