Add CRLs to rustls feature #2433
Merged
+202
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksenia-vazhdaeva
force-pushed
the
rustls-crl
branch
from
059c542
to
03ee65a
Compare
ksenia-vazhdaeva
force-pushed
the
rustls-crl
branch
from
03ee65a
to
b8e7562
Compare
seanmonstar
requested changes
Sep 30, 2024
src/lib.rs
Outdated
| @@ -349,6 +349,8 @@ if_hyper! { | |||
| #[cfg(feature = "__tls")] | |||
| // Re-exports, to be removed in a future release | |||
| pub use tls::{Certificate, Identity}; | |||
| #[cfg(feature = "__rustls")] | |||
| pub use tls::Crl; | |||
There was a problem hiding this comment.
Since the other re-exports will be removed from the top-level eventually, we probably shouldn't add this one. People should reach for it from reqwest::tls::....
There was a problem hiding this comment.
You are right. Thank you. I will fix this.
|
@seanmonstar thank you very much for the review! I hope that this PR will be useful for others. I replied to your comments. |
|
@seanmonstar could you, please, review PR after suggested changes? |
seanmonstar
reviewed
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.