Add lower speed limit to full async body retrievals. #2033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibbz00
force-pushed
the
lowest_allowed_speed
branch
from
7d82638
to
821b874
Compare
gibbz00
commented
Nov 13, 2023
gibbz00
force-pushed
the
lowest_allowed_speed
branch
from
821b874
to
ec1bc41
Compare
|
In #2237, we added the ability to timeout on very slow reads. Importantly, it applies to all reads (where as this PR applies just to It should be possible for someone to implement a "speed limit" outside of reqwest, using the streaming methods. Implementing inside reqwest is still a possibility, in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: hyperium/hyper#3402
No breaking changes were added and this time I made sure to not touch changelog.md :3
(Note: added dependency is only a dev-dependency.)