Add Response::into_parts
#1951
Closed
Add Response::into_parts
#1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a |
|
Oh yeah that was what I meant 🤦. So should I add that as well since there will be a lot rewritten with hyper 1.0 anyway? |
|
I think so. I think it's better than an into_parts methodml (I'd suggest removing that). |
|
Yeah I guess that makes sense since converting to a hyper style response was really the reason I made this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when using reqwest as a http client in a proxy server and you need to convert the response type without cloning everything.
I also had implemented
From<Request> for http::Request<hyper::Body>but since this would break with hyper 1.0 I decided to leave it out.