Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge into HPI? #17

Open
boehs opened this issue Nov 1, 2021 · 2 comments
Open

merge into HPI? #17

boehs opened this issue Nov 1, 2021 · 2 comments
Labels
question Further information is requested

Comments

@boehs
Copy link

boehs commented Nov 1, 2021

I see many are custom coded, why are they a part of their own repo and not submitted into the base HPI?

@seanbreckenridge
Copy link
Owner

seanbreckenridge commented Nov 1, 2021

This is purposefully not merged into HPI -- for some context you can look at DESIGN and MODULE_DESIGN docs

In essence, HPI is meant to act as sort of a configuration layer with lots of helpers for loading your data, but it isn't feasible to support every use case since new sites that have your data appear all the time, and everyone uses different sites.

This isn't a fork (anymore, it was at one point), its just additional modules that I maintain -- since this is a namespace package (see here) you can install both of these at the same time -- see instructions

Merging all these modules into @karlicoss 's HPI would mean that he would have to support/help maintain all these additional sources which are mostly handled/used by me, while I'm happy to do so here. It also prevents HPI from having way too many modules and becoming unmaintainable, while at the same time people are still able to easily extend and add their own modules

Is still a point of discussion as far as HPI goes, see here

@seanbreckenridge
Copy link
Owner

seanbreckenridge commented Nov 1, 2021

Am fine to keep this issue open, I can see people getting confused about this pretty easily

@seanbreckenridge seanbreckenridge added the question Further information is requested label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants