Use AnonymizedFaker for primary keys
#1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
changed the title
AnonymizedFaker for primary key columnsAnonymizedFaker for primary keys
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 50 50
Lines 4821 4823 +2
=======================================
+ Hits 4692 4694 +2
Misses 129 129 ☔ View full report in Codecov by Sentry. |
|
Results of the change: |
frances-h
reviewed
Mar 8, 2024
I can't write a test which actually verifies the logic, since that requires SDV-Enterprise. I can add a unit test that runs through the logic though. |
frances-h
approved these changes
Mar 8, 2024
| @@ -1496,6 +1496,40 @@ def test__create_config_with_address_columns(self): | |||
| } | |||
| assert config == expected_config | |||
|
|
|||
| def test__create_config_with_contextual_column_as_primary_key(self): | |||
| """Test it when a conextual column is a primary key.""" | |||
There was a problem hiding this comment.
typo: conextual -> contextual
R-Palazzo
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86azdzv1n, Resolve #1807.