Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strict boundaries even when transform strategy is used #820

Closed
amontanez24 opened this issue May 24, 2022 · 0 comments · Fixed by #850
Closed

Support strict boundaries even when transform strategy is used #820

amontanez24 opened this issue May 24, 2022 · 0 comments · Fixed by #850
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented May 24, 2022

Problem Description

As a user, it would be useful if I could define range or inequality constraints without having to depend on reject sampling.

Expected behavior

Currently, the strict parameter in the range and inequality constraints can only be enforced using reject sampling. It is not guaranteed to work when set to True if the handling_strategy is set to transform.

  • Improve both constraints to support the strict parameter being set to True when using the transform strategy.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
3 participants