Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameters related to distribution search and change default #767

Closed
amontanez24 opened this issue Apr 25, 2022 · 2 comments · Fixed by #791
Closed

Remove parameters related to distribution search and change default #767

amontanez24 opened this issue Apr 25, 2022 · 2 comments · Fixed by #791
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

Since the univariate distribution search seems to be slow, we want to remove this option from the user facing API and replace it as the default.

Expected behavior

  • The GaussianCopula and CopulaGAN tabular models should default to truncated_gaussian since that can fit most distributions
  • univariate, parametric, bounded, semi_bounded, parametric_bounded, parametric_semi_bounded should be removed from the _DISTRIBUTIONS dict and from the docstring in the readme.
  • Users should still be able to provide all other distributions (beta, gaussian, gamma, student_t, gaussian_kde, truncated_gaussian)
@amontanez24 amontanez24 added feature request Request for a new feature pending review labels Apr 25, 2022
@fealho
Copy link
Member

fealho commented Apr 28, 2022

@amontanez24 Should I delete it from the tutorials as well?

@amontanez24
Copy link
Contributor Author

@amontanez24 Should I delete it from the tutorials as well?

@npatki I'd say yes right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
2 participants