Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename file_path to filepath parameter in ExcelHandler #2055

Closed
srinify opened this issue Jun 11, 2024 · 0 comments · Fixed by #2058
Closed

Rename file_path to filepath parameter in ExcelHandler #2055

srinify opened this issue Jun 11, 2024 · 0 comments · Fixed by #2058
Assignees
@amontanez24
Labels
feature request Request for a new feature
Milestone
1.14.0

Comments

@srinify
Copy link
Contributor

srinify commented Jun 11, 2024 •
edited
Loading

In ExcelHandler, the parameter for specifying the location to the XLS file is file_path. To keep things standardized across SDV, let's renamed this to filepath.

Relevant Docs: https://docs.sdv.dev/sdv/multi-table-data/data-preparation/loading-data/excel#read

Reminder: Let's update the docs after release
@srinify srinify added the feature request Request for a new feature label Jun 11, 2024
@srinify srinify changed the title Update file_path to filepath parameter in ExcelHandler Rename file_path to filepath parameter in ExcelHandler Jun 11, 2024
@amontanez24 amontanez24 self-assigned this Jun 11, 2024
@amontanez24 amontanez24 added this to the 1.13.2 milestone Jun 11, 2024
@amontanez24 amontanez24 mentioned this issue Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

Rename file_path to filepath parameter in ExcelHandler sdv-dev/SDV
2 participants
@srinify @amontanez24