Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column relationship warning should be raised during synthesizer initialization only #1750

Closed
R-Palazzo opened this issue Jan 22, 2024 · 0 comments · Fixed by #1766
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@R-Palazzo
Copy link
Contributor

Environment Details

SDV: 1.9.0

Error Description

As a user, when I define a column relationship for which I don't have access to the material to use it properly, I see a warning. This warning should be raised only during the synthesizer initialization and not during the column relationship definition.

Steps to reproduce

The following snippet code:

from sdv.metadata import SingleTableMetadata
from sdv.single_table import GaussianCopulaSynthesizer

metadata = SingleTableMetadata().load_from_dict({
    'columns': {
        'country': {'sdtype': 'country_code'},
        'city': {'sdtype': 'city'},
    }
})
metadata.add_column_relationship('address', ['country', 'city'])

raise this warning:
UserWarning: The metadata contains a column relationship of type 'address'. which requires the address add-on.This relationship will be ignored. For higher quality data in this relationship, please inquire about the SDV Enterprise tier.
The same warning is also raised after by:

synthesizer = GaussianCopulaSynthesizer(metadata)

Expected behavior

The warning should be raised during the syntheiszer initialization only.

@R-Palazzo R-Palazzo added bug Something isn't working new Automatic label applied to new issues labels Jan 22, 2024
@npatki npatki removed the new Automatic label applied to new issues label Jan 22, 2024
@amontanez24 amontanez24 changed the title Column relationship warning should be raised during syntheiszer initialization only Column relationship warning should be raised during synthesizer initialization only Jan 22, 2024
@R-Palazzo R-Palazzo mentioned this issue Feb 1, 2024
@R-Palazzo R-Palazzo added this to the 1.10.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants