Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleTablePreset uses FrequencyEncoder #1695

Closed
R-Palazzo opened this issue Nov 28, 2023 · 0 comments · Fixed by #1701
Closed

SingleTablePreset uses FrequencyEncoder #1695

R-Palazzo opened this issue Nov 28, 2023 · 0 comments · Fixed by #1701
Assignees
@fealho
Labels
feature request Request for a new feature
Milestone
1.8.0

Comments

@R-Palazzo
Copy link
Contributor

Problem Description

Currently, SingleTablePreset is using the FrequencyEncoder for categorical columns
https://github.com/sdv-dev/SDV/blob/9ade85bf9c5cae063781e6573198141a13dc7b4b/sdv/lite/single_table.py#L41C1-L41C1

Expected behavior

This synthesizer should use default RDT transformers
@R-Palazzo R-Palazzo added feature request Request for a new feature new Automatic label applied to new issues labels Nov 28, 2023
@amontanez24 amontanez24 removed the new Automatic label applied to new issues label Nov 29, 2023
@fealho fealho mentioned this issue Nov 30, 2023
Merged
@amontanez24 amontanez24 added this to the 1.8.0 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Remove unnecessary FrequencyEncoder assignment sdv-dev/SDV
3 participants
@amontanez24 @fealho @R-Palazzo