Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve column names being integers #816

Closed
wants to merge 2 commits into from

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Apr 30, 2024

resolves sdv-dev/SDV#1935
CU-86b04ut1e

Transformers assume data column values are strings but they can be numerical (int) so convert it to string to avoid type errors.
Put the change in hyper transformer over the sdv repo because this allows us to maintain integrity of the input data and the created synthetic data (avoid type changing of columns). The changes are build for intermediate steps so it won't affect the data itself.

@sdv-team
Copy link
Contributor

@lajohn4747 lajohn4747 marked this pull request as ready for review April 30, 2024 17:25
@lajohn4747 lajohn4747 requested a review from a team as a code owner April 30, 2024 17:25
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integration test as well?

@lajohn4747 lajohn4747 marked this pull request as draft May 1, 2024 14:24
@lajohn4747
Copy link
Contributor Author

This issue is a bit more nuanced, closing and moving fix back to SDV repository

@lajohn4747 lajohn4747 closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesizers crash when column names are integers (TypeError: unsupported operand)
3 participants