Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Stereo impulse responses #479

Open
flutomax opened this issue Jun 4, 2024 · 7 comments
Open

[FEATURE] Stereo impulse responses #479

flutomax opened this issue Jun 4, 2024 · 7 comments
Labels
enhancement New feature or request priority:low Low priority issues

Comments

@flutomax
Copy link

flutomax commented Jun 4, 2024

Is it possible to support IR in stereo mode in the future? In other words, can I count on downloading stereo WAV files containing IR in order to apply convolution for the left and right channels separately?
I would really like to be able to work with a plug-in with such a feature.

@flutomax flutomax added enhancement New feature or request priority:low Low priority issues unread This issue is new and hasn't been seen by the maintainers yet labels Jun 4, 2024
@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label Jul 21, 2024
@sdatkinson
Copy link
Owner

Could've sworn there was an Issue for this already. Regardless, yes, I'm open to this.

@sdatkinson sdatkinson changed the title [FEATURE] Support IR in stereo mode [FEATURE] Stereo impulse responses Jul 21, 2024
@flutomax
Copy link
Author

Could've sworn there was an Issue for this already. Regardless, yes, I'm open to this.

How then? Creating two instances of a plugin for the left and right channels is somehow archaic.

@DomMcsweeney
Copy link

Stereo is highly requested, but it's pretty easy to work around this until it's fixed.
Even though most cab IRs are mono, stereo files can be loaded in NadIR by STL Tones. Download link at the bottom of this page (in the emissary bundle): https://www.stltones.com/pages/file-downloads

For now, if you want a full stereo route from input to output, you can add two instances of NAM on a track, and for example, in Reaper, use the output pins and choose 1>1 ... 2 > 2, respectively for each instance of NAM.

This is how I setup NAM to be fully stereo, it takes a few clicks and then you can save the fx chain for later recall:
image

@flutomax
Copy link
Author

flutomax commented Aug 3, 2024

I suspect that the author did not use the regular convolution class WDL_ConvolutionEngine or WDL_ConvolutionEngine_Div from the IPlug2 framework. It just has the ability to work in stereo mode. I wonder what good reasons the author had for not using this convolution class?

@sdatkinson
Copy link
Owner

@flutomax the reason is that I started this project for fun, and it was more fun for me to write the code than to use someone else's 🙂

For sure, if someone else were doing this then they might consider doing it another way like using something off the shelf.

@flutomax

This comment was marked as off-topic.

@sdatkinson
Copy link
Owner

Every comment on every repo shows up as an email in my inbox. Please keep discussion here related to working on the Issues.

To clarify, when I said

Could've sworn there was an Issue for this already. Regardless, yes, I'm open to this.

I meant that I intend to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority issues
Projects
None yet
Development

No branches or pull requests

3 participants