Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make core NAM interfaces mono #77

Closed
mikeoliphant opened this issue Oct 2, 2023 · 4 comments · Fixed by #78
Closed

Make core NAM interfaces mono #77

mikeoliphant opened this issue Oct 2, 2023 · 4 comments · Fixed by #78
Assignees
@mikeoliphant

Comments

@mikeoliphant
Copy link
Contributor

Along with the other cleanup of the core interfaces, I think it makes sense to consider making the model processing mono (rather than multi-channel).

There isn't any internal support for more than a single channel, and it would make the interface cleaner.
@sdatkinson
Copy link
Owner

Great suggestion. I like it.

@mikeoliphant
Copy link
Contributor Author

It also has the benefit of making #27 much simpler to resolve.

@mikeoliphant
Copy link
Contributor Author

Btw, I'd be happy to do a PR for this and #27, along with removing the input/output gain. No worries if you'd rather do it yourself, though.

@sdatkinson
Copy link
Owner

Go for it! 🙂

@mikeoliphant mikeoliphant mentioned this issue Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeoliphant mikeoliphant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Processing interface cleanup mikeoliphant/NeuralAmpModelerCore
2 participants
@mikeoliphant @sdatkinson