Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete redundancy #1415

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Delete redundancy #1415

merged 3 commits into from
Sep 5, 2024

Conversation

roynalnaruto
Copy link

Delete redundancy from code base:

  • The disable_proof_aggregation feature is no longer useful as the zstd-decoder itself is quite expensive. We can instead refactor the Batch Circuit in the future to rethink and allow cheap/fast tests
  • Since Curie hardfork has been finalised, we no longer need logic to:
    • Differentiate pre/post Curie
    • Identify Curie's fork block

@roynalnaruto roynalnaruto changed the title Chore/delete redundant logic Delete redundant logic Sep 3, 2024
@roynalnaruto roynalnaruto changed the title Delete redundant logic Delete redundancy Sep 3, 2024
Copy link

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not very confident the CI will pass. If i wrote some tests related to the fork check logic (i dont' know now, too long ago), it may break. Anyway, if ci passes, it can be merged.

@roynalnaruto roynalnaruto merged commit e609b72 into develop Sep 5, 2024
19 checks passed
@roynalnaruto roynalnaruto deleted the chore/delete-redundant-logic branch September 5, 2024 16:06
@roynalnaruto roynalnaruto mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants