Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add challenge randomness #36

Closed
wants to merge 6 commits into from

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Apr 26, 2023

Reference zkevm-circuits PRs:

privacy-scaling-explorations/zkevm-circuits#965
privacy-scaling-explorations/zkevm-circuits#1020

Summary

  1. Add struct Challenges contains field mpt_word and function exprs and values.

  2. Use Challenges<Expression> in configure and Challenges<Value> in assign for randomness.

  3. Update related code of mpt_table and mpt_update.

@silathdiir silathdiir marked this pull request as draft April 26, 2023 10:04
@silathdiir silathdiir force-pushed the refactor/challenge-api branch 2 times, most recently from 816767c to 55d9764 Compare April 26, 2023 15:10
@silathdiir silathdiir changed the title [WIP] refactor: add Challenge API refactor: add challenge randomness Apr 27, 2023
@silathdiir silathdiir marked this pull request as ready for review April 27, 2023 01:41
src/gadgets/mpt_update.rs Outdated Show resolved Hide resolved
src/gadgets/mpt_update.rs Outdated Show resolved Hide resolved
silathdiir and others added 2 commits April 27, 2023 14:10
Co-authored-by: z2trillion <z2trillion@users.noreply.github.com>
Co-authored-by: z2trillion <z2trillion@users.noreply.github.com>
@z2trillion z2trillion changed the base branch from feat/refactor to feat/refactor_nonce May 23, 2023 01:09
@z2trillion
Copy link
Member

sorry, i ended up using #41 instead.

@z2trillion z2trillion closed this May 30, 2023
@z2trillion z2trillion deleted the refactor/challenge-api branch August 4, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants