Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.13-dev #99

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

jarrodmillman
Copy link
Member

No description provided.

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

Looks like an import from typing.io that should come straight from typing.

@jarrodmillman
Copy link
Member Author

jarrodmillman commented Jul 4, 2024

Yes, that is the error. I am not sure where it is coming from and haven't had time to track it down. I suspect it is due to either ics-py or ics_vtimezones, but I haven't checked.

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

from importlib_resources._py3 import

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

Technically, this should be a dependency requirement on ics_vtimezones, but probably fine to set it in our package.

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

Uh oh, they have a version pin 😂

    ics-vtimezones 2020.1 depends on importlib_resources<2.0 and >=1.4

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

We had an issue with this before, but seems OK now — see #89

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

According to SPEC0, we can drop 3.8 and 3.9 if we want to.

@stefanv
Copy link
Member

stefanv commented Jul 4, 2024

Feel free to revert that last commit if you want to keep 3.8, 3.9 support.

I couldn't find where to change the pyupdate language version; maybe not used for this project yet.

@jarrodmillman
Copy link
Member Author

The only place we use this is pinned to Python 3.8 (netlify).

@jarrodmillman
Copy link
Member Author

I couldn't find where to change the pyupdate language version; maybe not used for this project yet.

requires-python = ">=3.8"

@jarrodmillman jarrodmillman merged commit 3f91f86 into scientific-python:main Jul 5, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants