Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: consider_namespace_packages now required for pytest 8.2 or after #241

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 4, 2024

Fix #240

@pllim pllim marked this pull request as ready for review March 4, 2024 20:48
now required for pytest 8.2 or after
@pllim
Copy link
Contributor Author

pllim commented Mar 4, 2024

After this is merge, should rerun CI over at https://github.com/astropy/pytest-filter-subpackage/ to make sure its devdeps is green too.

@pllim pllim requested review from bsipocz and saimn March 4, 2024 20:52
@bsipocz bsipocz added this to the 1.3.0 milestone Mar 5, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pllim!

@bsipocz bsipocz merged commit 74be2dd into scientific-python:main Mar 5, 2024
20 checks passed
@pllim pllim deleted the fix-pytestdev-8.2 branch March 5, 2024 21:13
@pllim
Copy link
Contributor Author

pllim commented Mar 5, 2024

I see that you already reran pytest-filter-subpackage CI and it is green now. Thanks a lot!

@bsipocz bsipocz modified the milestones: 1.3.0, 1.2.1 Mar 10, 2024
@bsipocz
Copy link
Member

bsipocz commented Mar 10, 2024

I ended up changing the changelog for this PR in the new v1.2.1 release as I'm sure there'll be more breakage from 8.2....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants