bf(ZENKO-852): Prevent CI object name conflicts #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a per run prefix to objects and then checks for the prefix before deleting objects. This is to prevent concurrent test runs from deleting each others objects and causing a incorrect test failure.
tmacro
changed the title
ssalaues
approved these changes
Jul 26, 2018
JianqinWang
approved these changes
Jul 26, 2018
| @@ -107,7 +107,9 @@ def cleanup_bucket(bucket, replicated=False, delete_bucket=True): # noqa pylint: | |||
| objects = [] | |||
| versions = version_list['Versions'] | |||
| for v in versions: # pylint: disable=invalid-name | |||
| objects.append({'VersionId': v['VersionId'], 'Key': v['Key']}) | |||
| if v['Key'].startswith(conf.OBJ_PREFIX): | |||
There was a problem hiding this comment.
I think we could just specify prefix = conf.OBJ_PREFIX before calling list_object_versions() for more efficiency?
PS: I know this is merged already 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a per run prefix to objects and then checks for the prefix before deleting objects. This is to prevent concurrent test runs from deleting each others objects and causing a incorrect test failure.