feat: ZENKO-779 cloudserver refactor #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalaues
force-pushed
the
feature/ZENKO-779-cloudserver-refactor
branch
from
f06a207
to
b14d4ae
Compare
giacomoguiulfo
changed the title
| secret: | ||
| secretName: {{ template "cloudserver-front.fullname" . }}-proxy | ||
| {{- end }} | ||
| {{- end}} |
giacomoguiulfo
changed the title
ssalaues
force-pushed
the
feature/ZENKO-779-cloudserver-refactor
branch
2 times, most recently
from
1c977fd
to
c7a2eac
Compare
ploki
approved these changes
Jul 20, 2018
dora-korpar
reviewed
Jul 20, 2018
| value: "{{ .Values.proxy.http }}" | ||
| - name: HTTP_PROXY | ||
| value: "{{ .Values.proxy.http }}" | ||
| - name: https_proxy |
There was a problem hiding this comment.
why do we set https_proxy and HTTPS_PROXY if .Values.proxy.http is set?
There was a problem hiding this comment.
I remember there was a reason for this. @giacomoguiulfo Might have more insight
alexanderchan-scality
approved these changes
Jul 20, 2018
giacomoguiulfo
suggested changes
Jul 20, 2018
| value: "{{ .Release.Name }}-cloudserver,{{ .Values.endpoint }}" | ||
| - name: HEALTHCHECKS_ALLOWFROM | ||
| value: "{{ .Values.allowHealthchecksFrom }}" | ||
| {{- if .Values.storageLimit.enabled }} |
There was a problem hiding this comment.
This should be a child of orbit -> .Values.orbit...
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v1 | |||
| kind: Pod | |||
| metadata: | |||
| name: {{ template "cloudserver-front.fullname" . }}-test | |||
| name: {{ template "cloudserver.fullname" . }}-test | |||
There was a problem hiding this comment.
Since you are modifying this value already, a better name will be:
{{ template "cloudserver.fullname" . }}-service-test
charts/cloudserver/values.yaml
Outdated
| # This is a YAML-formatted file. | ||
| # Declare variables to be passed into your templates. | ||
|
|
||
| orbit: | ||
| enabled: true | ||
| endpoint: https://api.zenko.io | ||
| pushEndpoint: https://push.api.zenko.io | ||
| mode: push | ||
| managerMode: push | ||
| workerMode: poll | ||
| # When 'orbit.enabled' is 'true', these aren't used, please use | ||
| # https://zenko.io to manage your deployment | ||
| storageLimit: |
There was a problem hiding this comment.
storageLimit should be part of orbit.
|
@ploki I think the changes in the cloudserver manager commit |
ssalaues
force-pushed
the
feature/ZENKO-779-cloudserver-refactor
branch
5 times, most recently
from
90c3c99
to
698de82
Compare
added 2 commits
July 21, 2018 11:31
This allows for cloudserver to have multiple replicas plus a manager that can still properly report metrics back to Orbit.
ssalaues
force-pushed
the
feature/ZENKO-779-cloudserver-refactor
branch
2 times, most recently
from
37a91f0
to
3deebf4
Compare
added 4 commits
July 21, 2018 12:59
Upgrading should be seamless as long as all the old chart tar balls are deleted from Zenko/charts/zenko/charts and helm dependency build zenko is re-ran.
ssalaues
force-pushed
the
feature/ZENKO-779-cloudserver-refactor
branch
from
3deebf4
to
7b23822
Compare
giacomoguiulfo
approved these changes
Jul 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor abstracts some of the environment vars that are needed for both the manager and cloudserver workers. While the manager is a separate deployment, the "cloudserver" service still includes the manager in the load balancing since it is a fully capable cloudserver instance.
Regarding upgradability: Upgrading should be seamless as long as all the old chart tar balls are deleted from
Zenko/charts/zenko/chartsandhelm dependency build zenkois re-ran.