bug(zenko-699): Fix Lifecycle Test #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulreddy
approved these changes
Jul 11, 2018
ssalaues
suggested changes
Jul 11, 2018
| @@ -0,0 +1,75 @@ | |||
| nodeCount: &nodeCount 1 | |||
There was a problem hiding this comment.
Is this for local testing?
There was a problem hiding this comment.
Just posting here the discussion Taylor and I had offline:
The concern was fundamentally changing an existing cluster when running this make command but it seems like it already previously had this intended affect. It's out of the scope of this PR but we should look into changing up the Makefile to better suit our needs.
| image: | ||
| pullPolicy: Always | ||
| orbit: | ||
| endpoint: "http://ciutil-orbit-simulator:4222" |
There was a problem hiding this comment.
If this is for local testing do we want orbit-simulator references?
There was a problem hiding this comment.
orbit sim still runs for local test runs
tmacro
force-pushed
the
bugfix/ZENKO-699_Fix_Lifecycle_Test
branch
from
9235361
to
bde1e7f
Compare
ssalaues
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.