Feature/zenko 596 add redis ha option #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulreddy
requested changes
Jul 6, 2018
| @@ -41,7 +41,7 @@ spec: | |||
| - name: EXTENSIONS_REPLICATION_SOURCE_S3_PORT | |||
| value: "80" | |||
| - name: REDIS_HOST | |||
| value: "{{- printf "%s-%s" .Release.Name "redis" | trunc 63 | trimSuffix "-" -}}" | |||
| value: "{{- printf "%s-%s" .Release.Name "redis-ha-master-svc" | trunc 63 | trimSuffix "-" -}}" | |||
There was a problem hiding this comment.
Please don't change Backbeat, this breaks compatibility. Backbeat only writes to LocalCache atm.
There was a problem hiding this comment.
I added this because all of the other backbeat services are configured to use redis-ha and to make it uniform/prevent issues. If they all should be on localcache then we should make that change as well.
There was a problem hiding this comment.
I just saw that #160 switched all the backbeat redis to use the local cache (my branch was out of date). I'll drop this commit.
ssalaues
force-pushed
the
feature/ZENKO-596-add-redis-ha-option
branch
from
663e5cc
to
d93feb8
Compare
giacomoguiulfo
approved these changes
Jul 6, 2018
jonathan-gramain
approved these changes
Jul 6, 2018
rahulreddy
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.