feat: extend support without orbit #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomoguiulfo
requested review from
ssalaues,
tmacro,
alexanderchan-scality,
rahulreddy,
NicolasT and
vrancurel
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
4 times, most recently
from
bbbf3c4
to
74b2fa1
Compare
|
Impressive ! all access keys are in secrets ? |
|
I hope access keys are fake in the doc ;) |
tmacro
approved these changes
Jun 25, 2018
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
2 times, most recently
from
62dc3d5
to
b84fd08
Compare
ssalaues
suggested changes
Jul 3, 2018
| @@ -11,6 +11,8 @@ spec: | |||
| replicas: {{ .Values.replication.consumer.replicaCount }} | |||
| template: | |||
| metadata: | |||
| annotations: | |||
There was a problem hiding this comment.
It doesn't seem that this should be here if orbit isn't enabled. Should prob add a conditional for this.
| @@ -11,6 +11,8 @@ spec: | |||
| replicas: {{ .Values.replication.producer.replicaCount }} | |||
| template: | |||
| metadata: | |||
| annotations: | |||
There was a problem hiding this comment.
same here for orbit conditional
| @@ -11,6 +11,8 @@ spec: | |||
| replicas: {{ .Values.replication.status.replicaCount }} | |||
| template: | |||
| metadata: | |||
| annotations: | |||
There was a problem hiding this comment.
same here for orbit conditional
| @@ -15,17 +15,30 @@ spec: | |||
| release: {{ .Release.Name }} | |||
| template: | |||
| metadata: | |||
| annotations: | |||
There was a problem hiding this comment.
same here for orbit conditional
| @@ -1,8 +1,6 @@ | |||
| # Default values for backbeat. | |||
| # This is a YAML-formatted file. | |||
| # Declare variables to be passed into your templates. | |||
| orbit: | |||
There was a problem hiding this comment.
Instead of completely removing .Values.orbit consider moving it to .Values.global.orbit in each of the sub charts (the Zenko parent values will still overwrite these)
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
3 times, most recently
from
cd1eeae
to
7fd9b77
Compare
This was referenced Jul 6, 2018
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
4 times, most recently
from
f29760c
to
097016f
Compare
|
@NicolasT Any thoughts before we merge this? |
ssalaues
approved these changes
Jul 9, 2018
giacomoguiulfo
commented
Jul 10, 2018
charts/zenko/values.yaml
Outdated
| # When 'orbit.enabled' is 'true', these aren't used, please use | ||
| # https://zenko.io to manage your deployment | ||
| locationConstraints: {} | ||
| # awsbackend: |
There was a problem hiding this comment.
@ssalaues Do you think we should leave these comments under locationConstraints?
anurag4DSB
approved these changes
Jul 13, 2018
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
7 times, most recently
from
a100f9a
to
9d1aa30
Compare
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
3 times, most recently
from
7c107f3
to
56785bb
Compare
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
from
56785bb
to
1d6b042
Compare
giacomoguiulfo
force-pushed
the
feature/ZENKO-562-orbit-disabled
branch
from
1d6b042
to
6dbda62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several features to Zenko when Orbit is disabled:
Documentation
Instrucctions on the setup can be found in
charts/setup-no-orbit.md.Upgrades
If related configuration values are changed in
values.yml, ahelm dependency build zenko && helm upgrade zenko zenkocommand (assuming zenko is the release name) will restart the pods with the updated configuration.