Replace metalk8s-loki storageclass with metalk8s one #2759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use a single metalk8s storageclass instead of one per addon (e.g. metalk8s-loki). Refs: #2742
This is needed as Loki chart only allow to target a PV with its storageclass name and we now use a single storageclass for all addons. This change needs to be ported upstream so we can still upgrade Loki chart. Refs: #2742
This also adds a label on the PV so that we can now select the PV based on this label instead of the storageclass name. Refs: #2742
|
Thanks bert-e... And I can't re-open the PR because the target branch is deleted (can't change it either). :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component: salt, docs, charts
Context: See #2742
Summary:
Acceptance criteria:
Closes: #2742